I think the Settings page is a little cluttered, and I think it would be much nicer if split.
Besides an aesthetic change, I believe it would help in the long run, if more "router-like" settings are added to the interface later on.
I made some crappy mock-ups in M$ Paint:
Desvio
April 24, 2017, 9:23pm
2
In addition, Whitelist/Blacklist could be squished into one page.
DL6ER
April 24, 2017, 9:28pm
3
But it would be extraordinary long for users with long lists. Both lists deliver different (in fact 180° opposite) results, so having them separated sounds useful to me.
Desvio
April 24, 2017, 9:39pm
4
I had envisioned two columns, but if it would confuse users to have opposing lists on the same page, it makes sense to keep help requests to a minimum.
I believe this pull will satisfy this feature request:
pi-hole:devel
← pi-hole:tweak/settings_tabs
opened 02:12PM - 18 Oct 17 UTC
**By submitting this pull request, I confirm the following (please check boxes, … eg [X] - no spaces) _Failure to fill the template will close your PR_:**
***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request***
- [X] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).
- [X] I have checked that [another pull request](https://github.com/pi-hole/pi-hole/pulls) for this purpose does not exist.
- [X] I have considered, and confirmed that this submission will be valuable to others.
- [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
- [X] I give this submission freely, and claim no ownership to its content.
**How familiar are you with the codebase?:**
## 10
---
Replacement for stale PR https://github.com/pi-hole/AdminLTE/pull/489
Re-designed settings page using Bootstrap Tabs.
There is no functional change to any of the elements therein.
We can discuss further changes based on this.
Old:
![old](https://user-images.githubusercontent.com/16748619/31723437-1c8ac5d6-b41f-11e7-866d-82d84598d741.png)
New:
![new](https://user-images.githubusercontent.com/16748619/31723441-1ffc671a-b41f-11e7-8a7e-87759462ffa5.png)
![new2](https://user-images.githubusercontent.com/16748619/31723443-21355740-b41f-11e7-9b88-ed1d318bb412.png)
_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._